RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:47:46 +00:00
Code Issues Activity Actions

LibC: Prevent slowness and overrun in strdup/strndup

Browse source 
strdup: Because the length is already known at the time of copying, there is
no need to use strcpy (which has to check every single byte, and thus tends
to be slower than memcpy).

strndup: If 'str' is not NUL-terminated, strndup used to run off into the
adjacent memory region. This can be fixed by using the proper strlen variant:
strnlen.
This commit is contained in:
Ben Wiederhake 2020-08-23 12:34:08 +02:00 • committed by Andreas Kling
parent 2adc3c61a2
commit 9795c61464
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibC/string.cpp
View file

@ -94,13 +94,14 @@ char* strdup(const char* str)
{
size_t len = strlen(str);
char* new_str = (char*)malloc(len + 1);
strcpy(new_str, str);
memcpy(new_str, str, len);
new_str[len] = '\0';
return new_str;
}
char* strndup(const char* str, size_t maxlen)
{
size_t len = min(strlen(str), maxlen);
size_t len = strnlen(str, maxlen);
char* new_str = (char*)malloc(len + 1);
memcpy(new_str, str, len);
new_str[len] = 0;