RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 07:37:35 +00:00
Code Issues Activity Actions

Everywhere: Make use of container version of all_of

Browse source 
Problem:
- New `all_of` implementation takes the entire container so the user
  does not need to pass explicit begin/end iterators. This is unused
  except is in tests.

Solution:
- Make use of the new and more user-friendly version where possible.
This commit is contained in:
Lenny Maiorani 2021-07-25 15:05:48 -06:00 • committed by Andreas Kling
parent 2c042e3530
commit 97bd13264a
10 changed files with 10 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/OrdinaryFunctionObject.cpp
View file

@ -58,7 +58,7 @@ OrdinaryFunctionObject::OrdinaryFunctionObject(GlobalObject& global_object, cons
set_this_mode(ThisMode::Global);
// 15.1.3 Static Semantics: IsSimpleParameterList, https://tc39.es/ecma262/#sec-static-semantics-issimpleparameterlist
set_has_simple_parameter_list(all_of(m_parameters.begin(), m_parameters.end(), [&](auto& parameter) {
set_has_simple_parameter_list(all_of(m_parameters, [&](auto& parameter) {
if (parameter.is_rest)
return false;
if (parameter.default_value)

2
Userland/Libraries/LibJS/Runtime/Value.cpp
View file

@ -53,7 +53,7 @@ static bool is_valid_bigint_value(StringView string)
string = string.trim_whitespace();
if (string.length() > 1 && (string[0] == '-' || string[0] == '+'))
string = string.substring_view(1, string.length() - 1);
return all_of(string.begin(), string.end(), [](auto ch) { return isdigit(ch); });
return all_of(string, [](auto ch) { return isdigit(ch); });
}
ALWAYS_INLINE bool both_number(const Value& lhs, const Value& rhs)