RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 22:17:42 +00:00
Code Issues Activity Actions

Add close-on-exec flag for file descriptors.

Browse source 
I was surprised to find that dup()'ed fds don't share the close-on-exec flag.
That means it has to be stored separately from the FileDescriptor object.
This commit is contained in:
Andreas Kling 2018-11-13 01:36:31 +01:00
parent 19b9401487
commit 97c799576a
10 changed files with 74 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

6
VirtualFileSystem/FileDescriptor.h
View file

@ -53,10 +53,7 @@ public:
void setBlocking(bool b) { m_isBlocking = b; }
dword file_flags() const { return m_file_flags; }
int set_file_flags(dword flags) { m_file_flags = flags; return 0; }
dword fd_flags() const { return m_fd_flags; }
int set_fd_flags(dword flags) { m_fd_flags = flags; return 0; }
void set_file_flags(dword flags) { m_file_flags = flags; }
bool is_fifo() const { return m_fifo; }
FIFO::Direction fifo_direction() { return m_fifo_direction; }
@ -77,7 +74,6 @@ private:
#ifdef SERENITY
bool m_isBlocking { true };
dword m_fd_flags { 0 };
dword m_file_flags { 0 };
RetainPtr<FIFO> m_fifo;