RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 15:57:45 +00:00
Code Issues Activity Actions

LibWeb: Store HTML tag name token data as FlyString while parsing

Browse source 
This makes checking if a token is a specific tag O(1) instead of O(n).
This commit is contained in:
Andreas Kling 2022-10-04 18:27:02 +02:00
parent d39f4edc99
commit 97ca45d9c6
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/Parser/HTMLToken.h
View file

@ -134,7 +134,7 @@ public:
m_data.get<u32>() = code_point; m_data.get<u32>() = code_point;
} }
String const& comment() const FlyString const& comment() const
{ {
VERIFY(is_comment()); VERIFY(is_comment());
return m_string_data; return m_string_data;
@ -146,7 +146,7 @@ public:
m_string_data = move(comment); m_string_data = move(comment);
} }
String const& tag_name() const FlyString const& tag_name() const
{ {
VERIFY(is_start_tag() || is_end_tag()); VERIFY(is_start_tag() || is_end_tag());
return m_string_data; return m_string_data;
@ -350,7 +350,7 @@ private:
bool m_tag_self_closing_acknowledged { false }; bool m_tag_self_closing_acknowledged { false };
// Type::Comment (comment data), Type::StartTag and Type::EndTag (tag name) // Type::Comment (comment data), Type::StartTag and Type::EndTag (tag name)
String m_string_data; FlyString m_string_data;
Variant<Empty, u32, OwnPtr<DoctypeData>, OwnPtr<Vector<Attribute>>> m_data {}; Variant<Empty, u32, OwnPtr<DoctypeData>, OwnPtr<Vector<Attribute>>> m_data {};