RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 23:37:35 +00:00
Code Issues Activity Actions

LibJS: Validate Calendar.prototype.fields() values more strictly

Browse source 
This is a normative change in the Temporal spec.

See:

- 75b66d8
- 9c2262b
This commit is contained in:
Linus Groh 2021-09-02 21:31:41 +01:00
parent fb7b4caa57
commit 97cc8f4613
3 changed files with 88 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

29
Userland/Libraries/LibJS/Tests/builtins/Temporal/Calendar/Calendar.prototype.fields.js
View file

@ -5,7 +5,18 @@ describe("correct behavior", () => {
test("basic functionality", () => {
const calendar = new Temporal.Calendar("iso8601");
const array = ["foo", "bar", "baz"];
const array = [
"year",
"month",
"monthCode",
"day",
"hour",
"minute",
"second",
"millisecond",
"microsecond",
"nanosecond",
];
const fields = calendar.fields(array);
expect(fields).toEqual(array);
expect(fields).not.toBe(array);
@ -24,7 +35,21 @@ describe("errors", () => {
for (const value of [123, null, undefined, true, {}]) {
expect(() => {
calendar.fields([value]);
}).toThrowWithMessage(TypeError, "FIXME: Add a string for this error.");
}).toThrowWithMessage(TypeError, `Invalid calendar field ${value}, expected a string`);
}
});
test("iterator values must be valid field names", () => {
const calendar = new Temporal.Calendar("iso8601");
expect(() => {
calendar.fields(["foo"]);
}).toThrowWithMessage(RangeError, "Invalid calendar field 'foo'");
});
test("iterator values must not contain duplicates", () => {
const calendar = new Temporal.Calendar("iso8601");
expect(() => {
calendar.fields(["year", "month", "year", "month"]);
}).toThrowWithMessage(RangeError, "Duplicate calendar field 'year'");
});
});