RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:57:45 +00:00
Code Issues Activity Actions

2048: Do not default to only temporarily applying settings changes

Browse source 
Also tweak its text in the settings window to be clearer on what this
check box is doing. Seemed a bit confusing that settings changes
required an extra action to persist.
This commit is contained in:
Timothy Flynn 2021-05-18 09:01:25 -04:00 • committed by Andreas Kling
parent 1a66f487a5
commit 97cee35471
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Games/2048/GameSizeDialog.cpp
View file

@ -65,7 +65,7 @@ GameSizeDialog::GameSizeDialog(GUI::Window* parent, size_t board_size, size_t ta
evil_ai_checkbox.set_checked(m_evil_ai); evil_ai_checkbox.set_checked(m_evil_ai);
evil_ai_checkbox.on_checked = [this](auto checked) { m_evil_ai = checked; }; evil_ai_checkbox.on_checked = [this](auto checked) { m_evil_ai = checked; };
auto& temp_checkbox = main_widget.add<GUI::CheckBox>("Temporary"); auto& temp_checkbox = main_widget.add<GUI::CheckBox>("Temporarily apply changes");
temp_checkbox.set_checked(m_temporary); temp_checkbox.set_checked(m_temporary);
temp_checkbox.on_checked = [this](auto checked) { m_temporary = checked; }; temp_checkbox.on_checked = [this](auto checked) { m_temporary = checked; };

2
Userland/Games/2048/GameSizeDialog.h
View file

@ -23,5 +23,5 @@ private:
size_t m_board_size; size_t m_board_size;
size_t m_target_tile_power; size_t m_target_tile_power;
bool m_evil_ai; bool m_evil_ai;
bool m_temporary { true }; bool m_temporary { false };
}; };