mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 20:37:35 +00:00
LibJS: Make Value::to_string_without_side_effects() infallible
Work towards #20449.
This commit is contained in:
parent
b8f78c0adc
commit
97ebfd9f0f
69 changed files with 182 additions and 182 deletions
|
@ -68,7 +68,7 @@ Sheet::Sheet(Workbook& workbook)
|
|||
if (result.is_error()) {
|
||||
warnln("Spreadsheet: Failed to run runtime code:");
|
||||
auto thrown_value = *result.throw_completion().value();
|
||||
warn("Threw: {}", MUST(thrown_value.to_string_without_side_effects()));
|
||||
warn("Threw: {}", thrown_value.to_string_without_side_effects());
|
||||
if (thrown_value.is_object() && is<JS::Error>(thrown_value.as_object())) {
|
||||
auto& error = static_cast<JS::Error const&>(thrown_value.as_object());
|
||||
warnln(" with message '{}'", error.get_without_side_effects(vm.names.message));
|
||||
|
@ -560,7 +560,7 @@ JsonObject Sheet::to_json() const
|
|||
auto json = realm().global_object().get_without_side_effects("JSON");
|
||||
auto stringified_or_error = JS::call(vm(), json.as_object().get_without_side_effects("stringify").as_function(), json, it.value->evaluated_data());
|
||||
VERIFY(!stringified_or_error.is_error());
|
||||
data.set("value", stringified_or_error.release_value().to_string_without_side_effects().release_value_but_fixme_should_propagate_errors().to_deprecated_string());
|
||||
data.set("value", stringified_or_error.release_value().to_string_without_side_effects().to_deprecated_string());
|
||||
} else {
|
||||
data.set("value", it.value->data());
|
||||
}
|
||||
|
@ -691,7 +691,7 @@ JsonObject Sheet::gather_documentation() const
|
|||
if (!doc.is_string())
|
||||
return;
|
||||
|
||||
JsonParser parser(doc.to_string_without_side_effects().release_value_but_fixme_should_propagate_errors());
|
||||
JsonParser parser(doc.to_string_without_side_effects());
|
||||
auto doc_object = parser.parse();
|
||||
|
||||
if (!doc_object.is_error())
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue