RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 02:57:42 +00:00
Code Issues Activity Actions

LibHTML: Add support for <body bgcolor="#rrggbb" text="#rrggbb">

Browse source 
This patch implements basic support for presentational hints, which are
old-school HTML attributes that affect style.

You add support for a presentational hint attribute by overriding
Element::apply_presentational_hints(StyleProperties&) and setting all
of the corresponding CSS properties as appropriate.

To make the background color fill the entire document, not just the
bounds of the <body> element's LayoutNode, we special-case it in the
HtmlView::paint_event() code for now. I'm not entirely sure what the
nicest solution would be, but I'm sure we'll discover it eventually.
This commit is contained in:
Andreas Kling 2019-10-04 21:05:52 +02:00
parent a7ca719c4e
commit 9808d35554
12 changed files with 94 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibHTML/DOM/Document.h
View file

@ -9,6 +9,7 @@
#include <LibHTML/DOM/ParentNode.h>
class Frame;
class HTMLBodyElement;
class HTMLHtmlElement;
class HTMLHeadElement;
class LayoutNode;
@ -35,6 +36,7 @@ public:
const HTMLHtmlElement* document_element() const;
const HTMLHeadElement* head() const;
const HTMLBodyElement* body() const;
String title() const;
@ -44,6 +46,8 @@ public:
Frame* frame() { return m_frame.ptr(); }
const Frame* frame() const { return m_frame.ptr(); }
Color background_color() const;
private:
OwnPtr<StyleResolver> m_style_resolver;
NonnullRefPtrVector<StyleSheet> m_sheets;