RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:07:44 +00:00
Code Issues Activity Actions

LibHTML: Add support for <body bgcolor="#rrggbb" text="#rrggbb">

Browse source 
This patch implements basic support for presentational hints, which are
old-school HTML attributes that affect style.

You add support for a presentational hint attribute by overriding
Element::apply_presentational_hints(StyleProperties&) and setting all
of the corresponding CSS properties as appropriate.

To make the background color fill the entire document, not just the
bounds of the <body> element's LayoutNode, we special-case it in the
HtmlView::paint_event() code for now. I'm not entirely sure what the
nicest solution would be, but I'm sure we'll discover it eventually.
This commit is contained in:
Andreas Kling 2019-10-04 21:05:52 +02:00
parent a7ca719c4e
commit 9808d35554
12 changed files with 94 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Libraries/LibHTML/DOM/Element.h
View file

@ -1,7 +1,7 @@
#pragma once
#include <LibHTML/DOM/ParentNode.h>
#include <AK/String.h>
#include <LibHTML/DOM/ParentNode.h>
class Attribute {
public:
@ -42,6 +42,8 @@ public:
bool has_class(const StringView&) const;
virtual void apply_presentational_hints(StyleProperties&) const {}
private:
Attribute* find_attribute(const String& name);
const Attribute* find_attribute(const String& name) const;
@ -49,4 +51,3 @@ private:
String m_tag_name;
Vector<Attribute> m_attributes;
};