RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:57:45 +00:00
Code Issues Activity Actions

LibJS: Allow calling Array::create_from without allocating a Vector

Browse source 
This method works as-is with a Span instead of a Vector (with some minor
const correctness adjustments).
This commit is contained in:
Timothy Flynn 2022-01-30 16:52:40 -05:00 • committed by Linus Groh
parent 2e1db1b090
commit 98348d9a33
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibJS/Runtime/Array.h
View file

@ -8,6 +8,7 @@
#include <AK/Assertions.h>
#include <AK/Function.h>
#include <AK/Span.h>
#include <AK/Vector.h>
#include <LibJS/Runtime/Completion.h>
#include <LibJS/Runtime/GlobalObject.h>
@ -23,12 +24,12 @@ public:
static Array* create_from(GlobalObject&, Vector<Value> const&);
// Non-standard but equivalent to CreateArrayFromList.
template<typename T>
static Array* create_from(GlobalObject& global_object, Vector<T>& elements, Function<Value(T&)> map_fn)
static Array* create_from(GlobalObject& global_object, Span<T const> elements, Function<Value(T const&)> map_fn)
{
auto& vm = global_object.vm();
auto values = MarkedValueList { global_object.heap() };
values.ensure_capacity(elements.size());
for (auto& element : elements) {
for (auto const& element : elements) {
values.append(map_fn(element));
VERIFY(!vm.exception());
}