RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 00:47:36 +00:00
Code Issues Activity Actions

Kernel: Don't hold the process list lock while destructing the process

Browse source 
Once we remove the process from the process list, we're free to do
whatever we want without any locks.
This commit is contained in:
sin-ack 2021-08-15 08:25:29 +00:00 • committed by Andreas Kling
parent 4520863c0e
commit 98408b8920
1 changed files with 5 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Kernel/Process.cpp
View file

@ -302,16 +302,19 @@ bool Process::unref() const
// NOTE: We need to obtain the process list lock before doing anything,
// because otherwise someone might get in between us lowering the
// refcount and acquiring the lock.
return processes().with_exclusive([&](auto& list) {
auto did_hit_zero = processes().with_exclusive([&](auto& list) {
auto new_ref_count = deref_base();
if (new_ref_count > 0)
return false;
if (m_list_node.is_in_list())
list.remove(*const_cast<Process*>(this));
delete this;
return true;
});
if (did_hit_zero)
delete this;
return did_hit_zero;
}
// Make sure the compiler doesn't "optimize away" this function: