RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 18:42:43 +00:00
Code Issues Activity Actions

Kernel+LibC+LibCore: Implement symlinkat(2)

Browse source 
Co-Authored-By: Daniel Bertalan <dani@danielbertalan.dev>
This commit is contained in:
sin-ack 2022-10-01 11:15:02 +00:00 • committed by Andrew Kaster
parent 5c1d5ed51d
commit 9850a69cd1
5 changed files with 11 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Kernel/API/Syscall.h
View file

@ -413,6 +413,7 @@ struct SC_mknod_params {
struct SC_symlink_params {
StringArgument target;
StringArgument linkpath;
int dirfd;
};
struct SC_rename_params {

2
Kernel/Syscalls/link.cpp
View file

@ -29,7 +29,7 @@ ErrorOr<FlatPtr> Process::sys$symlink(Userspace<Syscall::SC_symlink_params const
auto target = TRY(get_syscall_path_argument(params.target));
auto linkpath = TRY(get_syscall_path_argument(params.linkpath));
TRY(VirtualFileSystem::the().symlink(credentials(), target->view(), linkpath->view(), current_directory()));
TRY(VirtualFileSystem::the().symlink(credentials(), target->view(), linkpath->view(), TRY(custody_for_dirfd(params.dirfd))));
return 0;
}

8
Userland/Libraries/LibC/unistd.cpp
View file

@ -672,12 +672,18 @@ int unlinkat(int dirfd, char const* pathname, int flags)
// https://pubs.opengroup.org/onlinepubs/9699919799/functions/symlink.html
int symlink(char const* target, char const* linkpath)
{
return symlinkat(target, AT_FDCWD, linkpath);
}
// https://pubs.opengroup.org/onlinepubs/9699919799/functions/symlinkat.html
int symlinkat(char const* target, int newdirfd, char const* linkpath)
{
if (!target || !linkpath) {
errno = EFAULT;
return -1;
}
Syscall::SC_symlink_params params { { target, strlen(target) }, { linkpath, strlen(linkpath) } };
Syscall::SC_symlink_params params { { target, strlen(target) }, { linkpath, strlen(linkpath) }, newdirfd };
int rc = syscall(SC_symlink, &params);
__RETURN_WITH_ERRNO(rc, rc, -1);
}

1
Userland/Libraries/LibC/unistd.h
View file

@ -95,6 +95,7 @@ int link(char const* oldpath, char const* newpath);
int unlink(char const* pathname);
int unlinkat(int dirfd, char const* pathname, int flags);
int symlink(char const* target, char const* linkpath);
int symlinkat(char const* target, int newdirfd, char const* linkpath);
int rmdir(char const* pathname);
int dup(int old_fd);
int dup2(int old_fd, int new_fd);

1
Userland/Libraries/LibCore/System.cpp
View file

@ -839,6 +839,7 @@ ErrorOr<void> symlink(StringView target, StringView link_path)
Syscall::SC_symlink_params params {
.target = { target.characters_without_null_termination(), target.length() },
.linkpath = { link_path.characters_without_null_termination(), link_path.length() },
.dirfd = AT_FDCWD,
};
int rc = syscall(SC_symlink, &params);
HANDLE_SYSCALL_RETURN_VALUE("symlink", rc, {});