RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:17:44 +00:00
Code Issues Activity Actions

LibWeb: Use EOF code point instead of Optional in CSS Tokenizer

Browse source 
Optional seems like a good idea, but in many places we were not
checking if it had a value, which was causing crashes when the
Tokenizer was given malformed input. Using an EOF value along with
is_eof() makes things a lot simpler.
This commit is contained in:
Sam Atkins 2021-07-02 19:44:43 +01:00 • committed by Andreas Kling
parent caff7fff94
commit 985ed47a38
2 changed files with 96 additions and 103 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/CSS/Parser/Tokenizer.h
View file

@ -71,10 +71,10 @@ public:
[[nodiscard]] Vector<Token> parse();
private:
[[nodiscard]] Optional<u32> next_code_point();
[[nodiscard]] Optional<u32> peek_code_point(size_t offset = 0) const;
[[nodiscard]] Optional<U32Twin> peek_twin() const;
[[nodiscard]] Optional<U32Triplet> peek_triplet() const;
[[nodiscard]] u32 next_code_point();
[[nodiscard]] u32 peek_code_point(size_t offset = 0) const;
[[nodiscard]] U32Twin peek_twin() const;
[[nodiscard]] U32Triplet peek_triplet() const;
[[nodiscard]] static Token create_new_token(Token::TokenType);
[[nodiscard]] static Token create_value_token(Token::TokenType, String value);