RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 13:37:44 +00:00
Code Issues Activity Actions

LibWeb: Add implementation of Node.compareDocumentPosition()

Browse source 
While looking into getting Duck Duck Go loading further in the
Browser, I noticed that it was complaining about the missing
method Node.compareDocumentPosition.

This change implements as much of the DOM spec as possible
with the current implementation of the DOM to date. The
implementation is validated by new tests in the Node.js.
This commit is contained in:
Brian Gianforcaro 2021-04-10 17:21:22 -07:00 • committed by Andreas Kling
parent 0f8932d7ab
commit 988c23fff0
4 changed files with 69 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibWeb/DOM/Node.h
View file

@ -100,6 +100,7 @@ public:
void insert_before(NonnullRefPtr<Node> node, RefPtr<Node> child, bool suppress_observers = false);
void remove(bool suppress_observers = false);
void remove_all_children(bool suppress_observers = false);
u16 compare_document_position(RefPtr<Node> other);
// NOTE: This is intended for the JS bindings.
bool has_child_nodes() const { return has_children(); }