From 989f965f5409634d7954bd23d0a93a1dcb710de2 Mon Sep 17 00:00:00 2001 From: Zaggy1024 Date: Wed, 12 Apr 2023 00:21:43 -0500 Subject: [PATCH] LibVideo: Dispatch PlaybackManager state changes after `on_enter()` Previously, the state change was dispatched before the new state that was adopted had been entered, causing it to have invalid state. --- Userland/Libraries/LibVideo/PlaybackManager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Userland/Libraries/LibVideo/PlaybackManager.cpp b/Userland/Libraries/LibVideo/PlaybackManager.cpp index b99381de35..5175e01825 100644 --- a/Userland/Libraries/LibVideo/PlaybackManager.cpp +++ b/Userland/Libraries/LibVideo/PlaybackManager.cpp @@ -313,8 +313,8 @@ ErrorOr PlaybackManager::PlaybackStateHandler::replace_handler_and_delete_ m_has_exited = true; dbgln("Changing state from {} to {}", temp_handler->name(), m_manager.m_playback_handler->name()); #endif - m_manager.dispatch_state_change(); TRY(m_manager.m_playback_handler->on_enter()); + m_manager.dispatch_state_change(); return {}; }