From 98c7fd7aedd2f113481327cb0a45698a89124c09 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sun, 13 Oct 2019 20:39:59 +0200 Subject: [PATCH] Kernel: Clarify code that saves FPU state after FNINIT After we clear the FPU state in a thread when it uses the FPU for the first time, we also save the clean slate in the thread's FPU state buffer. When we're doing that, let's write through current->fpu_state() just to make it clear what's going on. It was actually safe, since we'd just overwritten the g_last_fpu_thread pointer anyway, but this patch improves the communication of intent. Spotted by Bryan Steele, thanks! --- Kernel/Arch/i386/CPU.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Kernel/Arch/i386/CPU.cpp b/Kernel/Arch/i386/CPU.cpp index a890ede4dd..a7e4d112f5 100644 --- a/Kernel/Arch/i386/CPU.cpp +++ b/Kernel/Arch/i386/CPU.cpp @@ -222,7 +222,7 @@ void exception_7_handler(RegisterDump& regs) } else { asm volatile("fninit"); asm volatile("fxsave %0" - : "=m"(g_last_fpu_thread->fpu_state())); + : "=m"(current->fpu_state())); current->set_has_used_fpu(true); }