RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 00:27:43 +00:00
Code Issues Activity Actions

Kernel: Use KResultOr better in ProcessGroup construction

Browse source 
This allows us to use TRY() more.
This commit is contained in:
Andreas Kling 2021-09-05 21:48:04 +02:00
parent 540d62d3b2
commit 98dc08fe56
3 changed files with 11 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Kernel/Syscalls/setpgid.cpp
View file

@ -38,11 +38,7 @@ KResultOr<FlatPtr> Process::sys$setsid()
return EPERM;
// Create a new Session and a new ProcessGroup.
auto new_pg = ProcessGroup::try_create(ProcessGroupID(pid().value()));
if (!new_pg)
return ENOMEM;
m_pg = move(new_pg);
m_pg = TRY(ProcessGroup::try_create(ProcessGroupID(pid().value())));
m_tty = nullptr;
ProtectedDataMutationScope scope { *this };
m_protected_values.sid = pid().value();
@ -122,10 +118,7 @@ KResultOr<FlatPtr> Process::sys$setpgid(pid_t specified_pid, pid_t specified_pgi
return EPERM;
}
// FIXME: There are more EPERM conditions to check for here..
auto process_group = ProcessGroup::try_find_or_create(new_pgid);
if (!process_group)
return ENOMEM;
process->m_pg = move(process_group);
process->m_pg = TRY(ProcessGroup::try_find_or_create(new_pgid));
return 0;
}