RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00
Code Issues Activity Actions

LibGUI: Speed up Variant string conversion for string data

Browse source 
Add a fast path to Variant::to_deprecated_string() to return a copy
if the underlying data is of type DeprecatedString. This improves the
performance of models with a lot of string data.
This commit is contained in:
Tim Ledbetter 2023-02-09 19:19:17 +00:00 • committed by Ali Mohammad Pur
parent adb1c842c2
commit 99570cb0c4
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibGUI/Variant.h
View file

@ -204,6 +204,7 @@ public:
{
return visit(
[](Empty) -> DeprecatedString { return "[null]"; },
[](DeprecatedString v) { return v; },
[](Gfx::TextAlignment v) { return DeprecatedString::formatted("Gfx::TextAlignment::{}", Gfx::to_string(v)); },
[](Gfx::ColorRole v) { return DeprecatedString::formatted("Gfx::ColorRole::{}", Gfx::to_string(v)); },
[](Gfx::AlignmentRole v) { return DeprecatedString::formatted("Gfx::AlignmentRole::{}", Gfx::to_string(v)); },