From 99b263a2db0c2ca8486ee6bfd72118fd33f2bcca Mon Sep 17 00:00:00 2001 From: Max Trussell Date: Sun, 19 Dec 2021 00:34:01 -0800 Subject: [PATCH] Userland/Notify: Check if optional icon arg is null before loading The commandline "notify" application was always attempting to load an icon path from an optional argument, even when the argument was omitted. In this case, the image icon argument would be a null pointer and the notify program would crash. This fix adds a conditional to only attempt to load the icon file if the icon_path variable is not a null pointer --- Userland/Utilities/notify.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Userland/Utilities/notify.cpp b/Userland/Utilities/notify.cpp index 94df318139..151b12d694 100644 --- a/Userland/Utilities/notify.cpp +++ b/Userland/Utilities/notify.cpp @@ -25,7 +25,8 @@ int main(int argc, char** argv) auto notification = GUI::Notification::construct(); notification->set_text(message); notification->set_title(title); - notification->set_icon(Gfx::Bitmap::try_load_from_file(icon_path).release_value_but_fixme_should_propagate_errors()); + if (icon_path) + notification->set_icon(Gfx::Bitmap::try_load_from_file(icon_path).release_value_but_fixme_should_propagate_errors()); notification->show(); return 0;