RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:57:45 +00:00
Code Issues Activity Actions

LibWeb: Use unsigned long long for ReadableStreamBYOBRequest.respond

Browse source 
Now that the IDL generator supports this :^)
This commit is contained in:
Shannon Booth 2023-12-27 21:13:46 +13:00 • committed by Andreas Kling
parent e54f272024
commit 99bf986889
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Streams/ReadableStreamBYOBRequest.cpp
View file

@ -39,7 +39,7 @@ void ReadableStreamBYOBRequest::visit_edges(Cell::Visitor& visitor)
visitor.visit(m_view); visitor.visit(m_view);
} }
WebIDL::ExceptionOr<void> ReadableStreamBYOBRequest::respond(u64 bytes_written) WebIDL::ExceptionOr<void> ReadableStreamBYOBRequest::respond(WebIDL::UnsignedLongLong bytes_written)
{ {
// 1. If this.[[controller]] is undefined, throw a TypeError exception. // 1. If this.[[controller]] is undefined, throw a TypeError exception.
if (!m_controller) if (!m_controller)

3
Userland/Libraries/LibWeb/Streams/ReadableStreamBYOBRequest.h
View file

@ -11,6 +11,7 @@
#include <LibWeb/Bindings/PlatformObject.h> #include <LibWeb/Bindings/PlatformObject.h>
#include <LibWeb/Forward.h> #include <LibWeb/Forward.h>
#include <LibWeb/Streams/ReadableByteStreamController.h> #include <LibWeb/Streams/ReadableByteStreamController.h>
#include <LibWeb/WebIDL/Types.h>
namespace Web::Streams { namespace Web::Streams {
@ -28,7 +29,7 @@ public:
void set_view(JS::GCPtr<WebIDL::ArrayBufferView> value) { m_view = value; } void set_view(JS::GCPtr<WebIDL::ArrayBufferView> value) { m_view = value; }
WebIDL::ExceptionOr<void> respond(u64 bytes_written); WebIDL::ExceptionOr<void> respond(WebIDL::UnsignedLongLong bytes_written);
private: private:
explicit ReadableStreamBYOBRequest(JS::Realm&); explicit ReadableStreamBYOBRequest(JS::Realm&);

3
Userland/Libraries/LibWeb/Streams/ReadableStreamBYOBRequest.idl
View file

@ -3,7 +3,6 @@
interface ReadableStreamBYOBRequest { interface ReadableStreamBYOBRequest {
readonly attribute ArrayBufferView? view; readonly attribute ArrayBufferView? view;
// FIXME: Should be unsigned long long undefined respond([EnforceRange] unsigned long long bytesWritten);
undefined respond([EnforceRange] unsigned long bytesWritten);
// FIXME: undefined respondWithNewView(ArrayBufferView view); // FIXME: undefined respondWithNewView(ArrayBufferView view);
}; };