RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:27:35 +00:00
Code Issues Activity Actions

LibGUI: Allow bypassing hook when setting SpinBox range

Browse source 
Pass false to set_range to avoid on_change side-effects.
This commit is contained in:
thankyouverycool 2021-04-22 13:29:22 -04:00 • committed by Andreas Kling
parent f90c224fc5
commit 99e7ad4b76
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibGUI/SpinBox.cpp
View file

@ -63,7 +63,7 @@ void SpinBox::set_value(int value)
on_change(value); on_change(value);
} }
void SpinBox::set_range(int min, int max) void SpinBox::set_range(int min, int max, bool change)
{ {
VERIFY(min <= max); VERIFY(min <= max);
if (m_min == min && m_max == max) if (m_min == min && m_max == max)
@ -76,7 +76,7 @@ void SpinBox::set_range(int min, int max)
m_value = clamp(m_value, m_min, m_max); m_value = clamp(m_value, m_min, m_max);
if (m_value != old_value) { if (m_value != old_value) {
m_editor->set_text(String::number(m_value)); m_editor->set_text(String::number(m_value));
if (on_change) if (change && on_change)
on_change(m_value); on_change(m_value);
} }

2
Userland/Libraries/LibGUI/SpinBox.h
View file

@ -22,7 +22,7 @@ public:
int max() const { return m_max; } int max() const { return m_max; }
void set_min(int min) { set_range(min, max()); } void set_min(int min) { set_range(min, max()); }
void set_max(int max) { set_range(min(), max); } void set_max(int max) { set_range(min(), max); }
void set_range(int min, int max); void set_range(int min, int max, bool change = true);
Function<void(int value)> on_change; Function<void(int value)> on_change;