From 9a406ccba69ed9f62dcb8ba1d3a41f9dc11cdce7 Mon Sep 17 00:00:00 2001 From: Linus Groh Date: Fri, 9 Dec 2022 23:59:02 +0000 Subject: [PATCH] LibJS: Add spec comments to Value::to_numeric() --- Userland/Libraries/LibJS/Runtime/Value.cpp | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibJS/Runtime/Value.cpp b/Userland/Libraries/LibJS/Runtime/Value.cpp index 93bf2f7e4d..8615e9b693 100644 --- a/Userland/Libraries/LibJS/Runtime/Value.cpp +++ b/Userland/Libraries/LibJS/Runtime/Value.cpp @@ -561,10 +561,15 @@ ThrowCompletionOr Value::to_object(VM& vm) const // 7.1.3 ToNumeric ( value ), https://tc39.es/ecma262/#sec-tonumeric FLATTEN ThrowCompletionOr Value::to_numeric(VM& vm) const { - auto primitive = TRY(to_primitive(vm, Value::PreferredType::Number)); - if (primitive.is_bigint()) - return primitive; - return primitive.to_number(vm); + // 1. Let primValue be ? ToPrimitive(value, number). + auto primitive_value = TRY(to_primitive(vm, Value::PreferredType::Number)); + + // 2. If primValue is a BigInt, return primValue. + if (primitive_value.is_bigint()) + return primitive_value; + + // 3. Return ? ToNumber(primValue). + return primitive_value.to_number(vm); } constexpr bool is_ascii_number(u32 code_point)