RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:38:11 +00:00
Code Issues Activity Actions

LibJS: Basic NaN support

Browse source 
This patch adds js_nan() for constructing a NaN value. You can check
if a Value is NaN with Value::is_nan().
This commit is contained in:
Andreas Kling 2020-03-27 12:26:37 +01:00
parent 23c5323a70
commit 9a78b4af2c
3 changed files with 23 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Libraries/LibJS/Runtime/Value.cpp
View file

@ -49,9 +49,13 @@ String Value::to_string() const
if (is_undefined())
return "undefined";
if (is_number())
if (is_number()) {
if (is_nan())
return "NaN";
// FIXME: This needs improvement.
return String::number((i32)as_double());
}
if (is_object())
return as_object()->to_primitive(Object::PreferredType::String).to_string();
@ -108,14 +112,10 @@ Value Value::to_number() const
if (ok)
return Value(parsed_int);
//FIXME: Implement 'NaN'
ASSERT_NOT_REACHED();
break;
return js_nan();
}
case Type::Undefined:
//FIXME: Implement 'NaN'
ASSERT_NOT_REACHED();
return js_nan();
case Type::Object:
return m_value.as_object->to_primitive(Object::PreferredType::Number).to_number();
}