RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 09:14:58 +00:00
Code Issues Activity Actions

Kernel: Store IRQControllers in NonnullRefPtrs instead of RefPtrs

Browse source 
These are always non-null, so there's no point in storing them in a
nullable container.
This commit is contained in:
Idan Horowitz 2022-09-25 15:25:14 +03:00
parent 176989d811
commit 9abbeff79f
8 changed files with 13 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Kernel/Interrupts/IRQHandler.cpp
View file

@ -25,7 +25,6 @@ bool IRQHandler::eoi()
{
dbgln_if(IRQ_DEBUG, "EOI IRQ {}", interrupt_number());
if (!m_shared_with_others) {
VERIFY(!m_responsible_irq_controller.is_null());
m_responsible_irq_controller->eoi(*this);
return true;
}

2
Kernel/Interrupts/IRQHandler.h
View file

@ -40,7 +40,7 @@ protected:
private:
bool m_shared_with_others { false };
bool m_enabled { false };
LockRefPtr<IRQController> m_responsible_irq_controller;
NonnullLockRefPtr<IRQController> m_responsible_irq_controller;
};
}

2
Kernel/Interrupts/SharedIRQHandler.h
View file

@ -41,6 +41,6 @@ private:
explicit SharedIRQHandler(u8 interrupt_number);
bool m_enabled { true };
GenericInterruptHandler::List m_handlers;
LockRefPtr<IRQController> m_responsible_irq_controller;
NonnullLockRefPtr<IRQController> m_responsible_irq_controller;
};
}

2
Kernel/Interrupts/SpuriousInterruptHandler.h
View file

@ -42,7 +42,7 @@ private:
explicit SpuriousInterruptHandler(u8 interrupt_number);
bool m_enabled { false };
bool m_real_irq { false };
LockRefPtr<IRQController> m_responsible_irq_controller;
NonnullLockRefPtr<IRQController> m_responsible_irq_controller;
OwnPtr<GenericInterruptHandler> m_real_handler;
};
}