mirror of
https://github.com/RGBCube/serenity
synced 2025-07-24 22:17:42 +00:00
Kernel: Don't use a VLA for outgoing UDP packets
We had the same exact problem as da981578e3
but for UDP sockets.
This commit is contained in:
parent
da981578e3
commit
9ae02d4c92
1 changed files with 3 additions and 6 deletions
|
@ -96,18 +96,15 @@ KResultOr<size_t> UDPSocket::protocol_send(const UserOrKernelBuffer& data, size_
|
||||||
if (routing_decision.is_zero())
|
if (routing_decision.is_zero())
|
||||||
return EHOSTUNREACH;
|
return EHOSTUNREACH;
|
||||||
const size_t buffer_size = sizeof(UDPPacket) + data_length;
|
const size_t buffer_size = sizeof(UDPPacket) + data_length;
|
||||||
|
auto buffer = ByteBuffer::create_zeroed(buffer_size);
|
||||||
alignas(UDPPacket) u8 buffer[buffer_size];
|
auto& udp_packet = *reinterpret_cast<UDPPacket*>(buffer.data());
|
||||||
new (buffer) UDPPacket;
|
|
||||||
|
|
||||||
auto& udp_packet = *reinterpret_cast<UDPPacket*>(buffer);
|
|
||||||
udp_packet.set_source_port(local_port());
|
udp_packet.set_source_port(local_port());
|
||||||
udp_packet.set_destination_port(peer_port());
|
udp_packet.set_destination_port(peer_port());
|
||||||
udp_packet.set_length(buffer_size);
|
udp_packet.set_length(buffer_size);
|
||||||
if (!data.read(udp_packet.payload(), data_length))
|
if (!data.read(udp_packet.payload(), data_length))
|
||||||
return EFAULT;
|
return EFAULT;
|
||||||
|
|
||||||
auto result = routing_decision.adapter->send_ipv4(routing_decision.next_hop, peer_address(), IPv4Protocol::UDP, UserOrKernelBuffer::for_kernel_buffer(buffer), buffer_size, ttl());
|
auto result = routing_decision.adapter->send_ipv4(routing_decision.next_hop, peer_address(), IPv4Protocol::UDP, UserOrKernelBuffer::for_kernel_buffer(buffer.data()), buffer_size, ttl());
|
||||||
if (result.is_error())
|
if (result.is_error())
|
||||||
return result;
|
return result;
|
||||||
return data_length;
|
return data_length;
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue