RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:28:11 +00:00
Code Issues Activity Actions

unzip: Use StringView instead of DeprecatedString

Browse source
This commit is contained in:
implicitfield 2022-12-18 12:59:02 +02:00 • committed by Andreas Kling
parent a520894522
commit 9ae9d82a03
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Utilities/unzip.cpp
View file

@ -85,20 +85,18 @@ static bool unpack_zip_member(Archive::ZipMember zip_member, bool quiet)
ErrorOr<int> serenity_main(Main::Arguments arguments) ErrorOr<int> serenity_main(Main::Arguments arguments)
{ {
char const* path; StringView zip_file_path;
bool quiet { false }; bool quiet { false };
DeprecatedString output_directory_path; StringView output_directory_path;
Vector<StringView> file_filters; Vector<StringView> file_filters;
Core::ArgsParser args_parser; Core::ArgsParser args_parser;
args_parser.add_option(output_directory_path, "Directory to receive the archive content", "output-directory", 'd', "path"); args_parser.add_option(output_directory_path, "Directory to receive the archive content", "output-directory", 'd', "path");
args_parser.add_option(quiet, "Be less verbose", "quiet", 'q'); args_parser.add_option(quiet, "Be less verbose", "quiet", 'q');
args_parser.add_positional_argument(path, "File to unzip", "path", Core::ArgsParser::Required::Yes); args_parser.add_positional_argument(zip_file_path, "File to unzip", "path", Core::ArgsParser::Required::Yes);
args_parser.add_positional_argument(file_filters, "Files or filters in the archive to extract", "files", Core::ArgsParser::Required::No); args_parser.add_positional_argument(file_filters, "Files or filters in the archive to extract", "files", Core::ArgsParser::Required::No);
args_parser.parse(arguments); args_parser.parse(arguments);
DeprecatedString zip_file_path { path };
struct stat st = TRY(Core::System::stat(zip_file_path)); struct stat st = TRY(Core::System::stat(zip_file_path));
// FIXME: Map file chunk-by-chunk once we have mmap() with offset. // FIXME: Map file chunk-by-chunk once we have mmap() with offset.