RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:57:35 +00:00
Code Issues Activity Actions

readelf: Don't error out on invalid interpreter path

Browse source 
This lets us inspect ELF binaries with un-loadable program interpreters,
same as binutils and llvm-readelf.
This commit is contained in:
Andrew Kaster 2022-04-30 23:43:20 -06:00 • committed by Andreas Kling
parent 4b0b22d897
commit 9b041786ac
1 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Userland/Utilities/readelf.cpp
View file

@ -325,16 +325,14 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
if (interpreter_file_or_error.is_error()) { if (interpreter_file_or_error.is_error()) {
warnln("Unable to map interpreter file {}: {}", interpreter_path, interpreter_file_or_error.error()); warnln("Unable to map interpreter file {}: {}", interpreter_path, interpreter_file_or_error.error());
return -1; } else {
} auto interpreter_image_data = interpreter_file_or_error.value()->bytes();
auto interpreter_image_data = interpreter_file_or_error.value()->bytes(); ELF::Image interpreter_image(interpreter_image_data);
ELF::Image interpreter_image(interpreter_image_data); if (!interpreter_image.is_valid()) {
warnln("ELF interpreter image is invalid");
if (!interpreter_image.is_valid()) { }
warnln("ELF interpreter image is invalid");
return -1;
} }
int fd = TRY(Core::System::open(path, O_RDONLY)); int fd = TRY(Core::System::open(path, O_RDONLY));