RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00
Code Issues Activity Actions

LibWeb: Consider row computed height in total row min height of table

Browse source 
Fixes the issue that currently we do not consider table rows height
while calculating min row height even if it is definite value.
This commit is contained in:
Aliaksandr Kalenik 2023-04-28 00:35:47 +03:00 • committed by Andreas Kling
parent d06057f88b
commit 9b4cd0dab7
3 changed files with 33 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/Layout/TableFormattingContext.cpp
View file

@ -425,6 +425,16 @@ void TableFormattingContext::calculate_row_heights(LayoutMode layout_mode)
row.used_height = max(row.used_height, cell_state.border_box_height());
row.baseline = max(row.baseline, cell.baseline);
}
for (auto& row : m_rows) {
auto row_computed_height = row.box->computed_values().height();
if (row_computed_height.is_length()) {
auto height_of_containing_block = m_state.get(*row.box->containing_block()).content_height();
auto height_of_containing_block_as_length = CSS::Length::make_px(height_of_containing_block);
auto row_used_height = row_computed_height.resolved(row.box, height_of_containing_block_as_length).to_px(row.box);
row.used_height = max(row.used_height, row_used_height);
}
}
}
void TableFormattingContext::position_row_boxes(CSSPixels& total_content_height)