RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 19:22:45 +00:00
Code Issues Activity Actions

LibWeb: Stop using percentage column widths in compute_table_measures

Browse source
This commit is contained in:
Aliaksandr Kalenik 2023-01-14 15:52:54 +01:00 • committed by Andreas Kling
parent b44d977bf8
commit 9b6fcd8591
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibWeb/Layout/TableFormattingContext.cpp
View file

@ -127,7 +127,9 @@ void TableFormattingContext::compute_table_measures()
if (!computed_values.min_width().is_auto())
min_width = max(min_width, computed_values.min_width().resolved(cell.box, width_of_containing_block_as_length).to_px(cell.box));
CSSPixels max_width = computed_values.width().is_auto() ? max_content_width.value() : width;
// NOTE: percentage column width cannot be used because it cannot be resolved correctly
// when final table width is not known yet
CSSPixels max_width = !computed_values.width().is_length() ? max_content_width.value() : width;
if (!computed_values.max_width().is_none())
max_width = min(max_width, computed_values.max_width().resolved(cell.box, width_of_containing_block_as_length).to_px(cell.box));
@ -140,7 +142,11 @@ void TableFormattingContext::compute_table_measures()
}
cell.min_width = min_width + cell_intrinsic_offsets;
cell.max_width = max(max(width, min_width), max_width) + cell_intrinsic_offsets;
if (!computed_values.width().is_percentage()) {
cell.max_width = max(max(width, min_width), max_width) + cell_intrinsic_offsets;
} else {
cell.max_width = max(min_width, max_width) + cell_intrinsic_offsets;
}
max_cell_column_span = max(max_cell_column_span, cell.column_span);
}