RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 07:07:34 +00:00
Code Issues Activity Actions

AK: Use integral power for FixedPoint formatting

Browse source 
This removes an ifdef for the Kernel
This commit is contained in:
Hendiadyoin1 2022-01-27 13:23:36 +01:00 • committed by Brian Gianforcaro
parent 581c23dc55
commit 9ba9691d19
1 changed files with 2 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

10
AK/Format.cpp
View file

@ -7,6 +7,7 @@
#include <AK/CharacterTypes.h> #include <AK/CharacterTypes.h>
#include <AK/Format.h> #include <AK/Format.h>
#include <AK/GenericLexer.h> #include <AK/GenericLexer.h>
#include <AK/IntegralMath.h>
#include <AK/String.h> #include <AK/String.h>
#include <AK/StringBuilder.h> #include <AK/StringBuilder.h>
#include <AK/kstdio.h> #include <AK/kstdio.h>
@ -383,14 +384,7 @@ ErrorOr<void> FormatBuilder::put_fixed_point(
// place to start would be the following video from CppCon 2019: // place to start would be the following video from CppCon 2019:
// https://youtu.be/4P_kbF0EbZM (Stephan T. Lavavej “Floating-Point <charconv>: Making Your Code 10x Faster With C++17's Final Boss”) // https://youtu.be/4P_kbF0EbZM (Stephan T. Lavavej “Floating-Point <charconv>: Making Your Code 10x Faster With C++17's Final Boss”)
#ifdef KERNEL u64 scale = pow<u64>(10, precision);
// We don't have pow() in kernel land
u64 scale = 10;
for (size_t i = 0; i < precision - 1; i++) // TODO: not efficient
scale *= 10;
#else
u64 scale = pow(10.0, (double)precision);
#endif
auto fraction = (scale * fraction_value) / fraction_one; // TODO: overflows auto fraction = (scale * fraction_value) / fraction_one; // TODO: overflows
if (is_negative) if (is_negative)