RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:47:45 +00:00
Code Issues Activity Actions

LibWeb: Paint the focus outline using Painter::draw_focus_rect()

Browse source 
Now it actually looks like a classic focus outline and not some
misplaced border :^)
This commit is contained in:
Linus Groh 2022-03-26 00:53:31 +00:00
parent 642491fc74
commit 9bc7912f84
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/Painting/PaintableBox.cpp
View file

@ -156,7 +156,7 @@ void PaintableBox::paint(PaintContext& context, PaintPhase phase) const
if (phase == PaintPhase::FocusOutline && layout_box().dom_node() && layout_box().dom_node()->is_element() && verify_cast<DOM::Element>(*layout_box().dom_node()).is_focused()) {
// FIXME: Implement this as `outline` using :focus-visible in the default UA stylesheet to make it possible to override/disable.
auto focus_outline_rect = enclosing_int_rect(absolute_border_box_rect()).inflated(4, 4);
context.painter().draw_rect(focus_outline_rect, context.palette().focus_outline());
context.painter().draw_focus_rect(focus_outline_rect, context.palette().focus_outline());
}
}
@ -468,7 +468,7 @@ void PaintableWithLines::paint(PaintContext& context, PaintPhase phase) const
if (parent->is_focused()) {
// FIXME: Implement this as `outline` using :focus-visible in the default UA stylesheet to make it possible to override/disable.
auto focus_outline_rect = enclosing_int_rect(fragment.absolute_rect()).inflated(4, 4);
context.painter().draw_rect(focus_outline_rect, context.palette().focus_outline());
context.painter().draw_focus_rect(focus_outline_rect, context.palette().focus_outline());
}
}
}