RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:07:45 +00:00
Code Issues Activity Actions

Meta: Use proper versions in is_compiler_supported check in serenity.sh

Browse source 
We were checking the compilers against clang-12 and gcc-10. Since the
check itself is confusing, some comments are warranted.
This commit is contained in:
Andrew Kaster 2022-11-12 21:25:52 +00:00
parent d9c1eb860f
commit 9bf2a7c7e5
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Meta/serenity.sh
View file

@ -156,9 +156,11 @@ is_supported_compiler() {
if $COMPILER --version 2>&1 | grep "Apple clang" >/dev/null; then if $COMPILER --version 2>&1 | grep "Apple clang" >/dev/null; then
return 1 return 1
elif $COMPILER --version 2>&1 | grep "clang" >/dev/null; then elif $COMPILER --version 2>&1 | grep "clang" >/dev/null; then
[ "$MAJOR_VERSION" -gt 12 ] && return 0 # Clang version check
[ "$MAJOR_VERSION" -ge 13 ] && return 0
else else
[ "$MAJOR_VERSION" -gt 10 ] && return 0 # GCC version check
[ "$MAJOR_VERSION" -ge 12 ] && return 0
fi fi
return 1 return 1
} }