RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:48:11 +00:00
Code Issues Activity Actions

Kernel+LibC: Support passing O_CLOEXEC to pipe()

Browse source 
In the userspace, this mimics the Linux pipe2() syscall;
in the kernel, the Process::sys$pipe() now always accepts
a flags argument, the no-argument pipe() syscall is now a
userspace wrapper over pipe2().
This commit is contained in:
Sergey Bugaev 2019-08-05 15:29:05 +03:00 • committed by Andreas Kling
parent 55d7810fab
commit 9c3b1ca0c6
5 changed files with 17 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Kernel/Process.cpp
View file

@ -1194,20 +1194,25 @@ int Process::alloc_fd(int first_candidate_fd)
return fd;
}
int Process::sys$pipe(int pipefd[2])
int Process::sys$pipe(int pipefd[2], int flags)
{
if (!validate_write_typed(pipefd))
return -EFAULT;
if (number_of_open_file_descriptors() + 2 > max_open_file_descriptors())
return -EMFILE;
// Reject flags other than O_CLOEXEC.
if ((flags & O_CLOEXEC) != flags)
return -EINVAL;
u32 fd_flags = (flags & O_CLOEXEC) ? FD_CLOEXEC : 0;
auto fifo = FIFO::create(m_uid);
int reader_fd = alloc_fd();
m_fds[reader_fd].set(fifo->open_direction(FIFO::Direction::Reader));
m_fds[reader_fd].set(fifo->open_direction(FIFO::Direction::Reader), fd_flags);
pipefd[0] = reader_fd;
int writer_fd = alloc_fd();
m_fds[writer_fd].set(fifo->open_direction(FIFO::Direction::Writer));
m_fds[writer_fd].set(fifo->open_direction(FIFO::Direction::Writer), fd_flags);
pipefd[1] = writer_fd;
return 0;