RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:37:45 +00:00
Code Issues Activity Actions

Ladybird: Do not enable the reload button if history is empty

Browse source 
Not much of an issue currently, but will be once tabs are used to render
plain HTML.
This commit is contained in:
Timothy Flynn 2023-08-28 15:54:36 -04:00 • committed by Tim Flynn
parent 70830b711e
commit 9c4ce1b80b
5 changed files with 19 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Ladybird/AppKit/UI/TabController.mm
View file

@ -139,6 +139,10 @@ enum class IsHistoryNavigation {
- (void)reload:(id)sender
{
if (m_history.is_empty()) {
return;
}
m_is_history_navigation = IsHistoryNavigation::Yes;
auto url = m_history.current().url;
@ -179,6 +183,9 @@ enum class IsHistoryNavigation {
auto* navigate_forward_button = (NSButton*)[[self navigate_forward_toolbar_item] view];
[navigate_forward_button setEnabled:m_history.can_go_forward()];
auto* reload_button = (NSButton*)[[self reload_toolbar_item] view];
[reload_button setEnabled:!m_history.is_empty()];
}
- (void)showTabOverview:(id)sender
@ -232,6 +239,7 @@ enum class IsHistoryNavigation {
if (!_reload_toolbar_item) {
auto* button = [self create_button:NSImageNameRefreshTemplate
with_action:@selector(reload:)];
[button setEnabled:NO];
_reload_toolbar_item = [[NSToolbarItem alloc] initWithItemIdentifier:TOOLBAR_RELOAD_IDENTIFIER];
[_reload_toolbar_item setView:button];