From 9c63f9854b40041ba5615927b4837c3075d9bb97 Mon Sep 17 00:00:00 2001 From: Stephan Vedder Date: Mon, 13 Nov 2023 14:13:43 +0100 Subject: [PATCH] LibJS/JIT: Remove incorrect check for empty tag This check is not required and prevented put_by_value to take the actual fastpath. --- Userland/Libraries/LibJS/JIT/Compiler.cpp | 9 --------- 1 file changed, 9 deletions(-) diff --git a/Userland/Libraries/LibJS/JIT/Compiler.cpp b/Userland/Libraries/LibJS/JIT/Compiler.cpp index 105323c391..a9a5495955 100644 --- a/Userland/Libraries/LibJS/JIT/Compiler.cpp +++ b/Userland/Libraries/LibJS/JIT/Compiler.cpp @@ -2428,15 +2428,6 @@ void Compiler::compile_put_by_value(Bytecode::Op::PutByValue const& op) Assembler::Operand::Register(GPR2), Assembler::Operand::Mem64BaseAndOffset(GPR0, 0)); - // if (GPR2.is_empty()) goto slow_case; - m_assembler.mov(Assembler::Operand::Register(GPR1), Assembler::Operand::Register(GPR2)); - m_assembler.shift_right(Assembler::Operand::Register(GPR1), Assembler::Operand::Imm(TAG_SHIFT)); - m_assembler.jump_if( - Assembler::Operand::Register(GPR1), - Assembler::Condition::EqualTo, - Assembler::Operand::Imm(EMPTY_TAG), - slow_case); - // if (GPR2.is_accessor()) goto slow_case; m_assembler.mov(Assembler::Operand::Register(GPR1), Assembler::Operand::Register(GPR2)); m_assembler.shift_right(Assembler::Operand::Register(GPR1), Assembler::Operand::Imm(TAG_SHIFT));