From 9c71e43c3f8754a5fc2a5410b1c2bf45154d4689 Mon Sep 17 00:00:00 2001 From: Karol Kosek Date: Wed, 21 Jul 2021 15:58:03 +0200 Subject: [PATCH] LibAudio: Check if zero-bit padding is actually zero This might allow the program to return an error a bit quicker. --- Userland/Libraries/LibAudio/FlacLoader.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibAudio/FlacLoader.cpp b/Userland/Libraries/LibAudio/FlacLoader.cpp index 7110d77e2b..86e12e380c 100644 --- a/Userland/Libraries/LibAudio/FlacLoader.cpp +++ b/Userland/Libraries/LibAudio/FlacLoader.cpp @@ -512,7 +512,10 @@ FlacSubframeHeader FlacLoaderPlugin::next_subframe_header(InputBitStream& bit_st } // zero-bit padding - bit_stream.read_bit_big_endian(); + if (bit_stream.read_bit_big_endian() != 0) { + m_error_string = "Zero bit padding"; + return {}; + }; // subframe type (encoding) u8 subframe_code = bit_stream.read_bits_big_endian(6);