RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 18:18:12 +00:00
Code Issues Activity Actions

Everywhere: Remove some bitrotted "#if 0" blocks

Browse source
This commit is contained in:
Andreas Kling 2021-02-03 11:17:21 +01:00
parent ac59903c89
commit 9c77980965
3 changed files with 1 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/KSyms.cpp
View file

@ -117,12 +117,6 @@ static void load_kernel_sybols_from_data(const KBuffer& buffer)
NEVER_INLINE static void dump_backtrace_impl(FlatPtr base_pointer, bool use_ksyms) NEVER_INLINE static void dump_backtrace_impl(FlatPtr base_pointer, bool use_ksyms)
{ {
SmapDisabler disabler; SmapDisabler disabler;
#if 0
if (!current) {
//hang();
return;
}
#endif
if (use_ksyms && !g_kernel_symbols_available) { if (use_ksyms && !g_kernel_symbols_available) {
Processor::halt(); Processor::halt();
return; return;

34
Kernel/VM/InodeVMObject.cpp
View file

@ -98,40 +98,6 @@ void InodeVMObject::inode_contents_changed(Badge<Inode>, off_t offset, [[maybe_u
for (auto& physical_page : m_physical_pages) for (auto& physical_page : m_physical_pages)
physical_page = nullptr; physical_page = nullptr;
#if 0
size_t current_offset = offset;
size_t remaining_bytes = size;
const u8* data_ptr = data;
auto to_page_index = [] (size_t offset) -> size_t {
return offset / PAGE_SIZE;
};
if (current_offset & PAGE_MASK) {
size_t page_index = to_page_index(current_offset);
size_t bytes_to_copy = min(size, PAGE_SIZE - (current_offset & PAGE_MASK));
if (m_physical_pages[page_index]) {
auto* ptr = MM.quickmap_page(*m_physical_pages[page_index]);
memcpy(ptr, data_ptr, bytes_to_copy);
MM.unquickmap_page();
}
current_offset += bytes_to_copy;
data += bytes_to_copy;
remaining_bytes -= bytes_to_copy;
}
for (size_t page_index = to_page_index(current_offset); page_index < m_physical_pages.size(); ++page_index) {
size_t bytes_to_copy = PAGE_SIZE - (current_offset & PAGE_MASK);
if (m_physical_pages[page_index]) {
auto* ptr = MM.quickmap_page(*m_physical_pages[page_index]);
memcpy(ptr, data_ptr, bytes_to_copy);
MM.unquickmap_page();
}
current_offset += bytes_to_copy;
data += bytes_to_copy;
}
#endif
// FIXME: Consolidate with inode_size_changed() so we only do a single walk. // FIXME: Consolidate with inode_size_changed() so we only do a single walk.
for_each_region([](auto& region) { for_each_region([](auto& region) {
region.remap(); region.remap();

14
Userland/Libraries/LibGUI/TreeView.cpp
View file

@ -418,19 +418,7 @@ void TreeView::did_update_selection()
auto index = selection().first(); auto index = selection().first();
if (!index.is_valid()) if (!index.is_valid())
return; return;
#if 0
bool opened_any = false;
for (auto current = index; current.is_valid(); current = current.parent()) {
auto& metadata_for_ancestor = ensure_metadata_for_index(current);
if (!metadata_for_ancestor.open) {
metadata_for_ancestor.open = true;
opened_any = true;
}
}
if (opened_any)
update_content_size();
update();
#endif
if (activates_on_selection()) if (activates_on_selection())
activate(index); activate(index);
} }