RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:27:35 +00:00
Code Issues Activity Actions

AK: Convert a couple String-related declarations to east-const

Browse source 
Caught by clang-format-17. Note that clang-format-16 is fine with this
as well (it leaves the const placement alone), it just doesn't perform
the formatting to east-const itself.
This commit is contained in:
Timothy Flynn 2024-01-03 16:43:01 -05:00 • committed by Tim Flynn
parent b8cbc282f3
commit 9cab4958e6
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
AK/ByteString.h
View file

@ -189,7 +189,7 @@ public:
return bit_cast<u8>((*m_impl)[i]); return bit_cast<u8>((*m_impl)[i]);
} }
using ConstIterator = SimpleIterator<const ByteString, char const>; using ConstIterator = SimpleIterator<ByteString const, char const>;
[[nodiscard]] constexpr ConstIterator begin() const { return ConstIterator::begin(*this); } [[nodiscard]] constexpr ConstIterator begin() const { return ConstIterator::begin(*this); }
[[nodiscard]] constexpr ConstIterator end() const { return ConstIterator::end(*this); } [[nodiscard]] constexpr ConstIterator end() const { return ConstIterator::end(*this); }

4
AK/StringUtils.cpp
View file

@ -174,7 +174,7 @@ Optional<T> convert_to_uint_from_hex(StringView str, TrimWhitespace trim_whitesp
T value = 0; T value = 0;
auto const count = string.length(); auto const count = string.length();
const T upper_bound = NumericLimits<T>::max(); T const upper_bound = NumericLimits<T>::max();
for (size_t i = 0; i < count; i++) { for (size_t i = 0; i < count; i++) {
char digit = string[i]; char digit = string[i];
@ -213,7 +213,7 @@ Optional<T> convert_to_uint_from_octal(StringView str, TrimWhitespace trim_white
T value = 0; T value = 0;
auto const count = string.length(); auto const count = string.length();
const T upper_bound = NumericLimits<T>::max(); T const upper_bound = NumericLimits<T>::max();
for (size_t i = 0; i < count; i++) { for (size_t i = 0; i < count; i++) {
char digit = string[i]; char digit = string[i];

2
AK/StringView.h
View file

@ -83,7 +83,7 @@ public:
return m_characters[index]; return m_characters[index];
} }
using ConstIterator = SimpleIterator<const StringView, char const>; using ConstIterator = SimpleIterator<StringView const, char const>;
[[nodiscard]] constexpr ConstIterator begin() const { return ConstIterator::begin(*this); } [[nodiscard]] constexpr ConstIterator begin() const { return ConstIterator::begin(*this); }
[[nodiscard]] constexpr ConstIterator end() const { return ConstIterator::end(*this); } [[nodiscard]] constexpr ConstIterator end() const { return ConstIterator::end(*this); }