RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 19:27:35 +00:00
Code Issues Activity Actions

Kernel: Use u64 instead of size_t for File::can_read offset

Browse source 
This ensures offsets will not be truncated on large files on i686.
This commit is contained in:
Idan Horowitz 2022-01-25 20:17:49 +02:00
parent 0c630d5687
commit 9ce537d703
47 changed files with 47 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Devices/HID/KeyboardDevice.cpp
View file

@ -280,7 +280,7 @@ UNMAP_AFTER_INIT KeyboardDevice::~KeyboardDevice()
{
}
bool KeyboardDevice::can_read(const OpenFileDescription&, size_t) const
bool KeyboardDevice::can_read(const OpenFileDescription&, u64) const
{
return !m_queue.is_empty();
}

2
Kernel/Devices/HID/KeyboardDevice.h
View file

@ -26,7 +26,7 @@ public:
// ^CharacterDevice
virtual ErrorOr<size_t> read(OpenFileDescription&, u64, UserOrKernelBuffer&, size_t) override;
virtual bool can_read(const OpenFileDescription&, size_t) const override;
virtual bool can_read(const OpenFileDescription&, u64) const override;
virtual ErrorOr<size_t> write(OpenFileDescription&, u64, const UserOrKernelBuffer&, size_t) override { return EINVAL; }
virtual bool can_write(const OpenFileDescription&, size_t) const override { return true; }

2
Kernel/Devices/HID/MouseDevice.cpp
View file

@ -18,7 +18,7 @@ MouseDevice::~MouseDevice()
{
}
bool MouseDevice::can_read(const OpenFileDescription&, size_t) const
bool MouseDevice::can_read(const OpenFileDescription&, u64) const
{
SpinlockLocker lock(m_queue_lock);
return !m_queue.is_empty();

2
Kernel/Devices/HID/MouseDevice.h
View file

@ -24,7 +24,7 @@ public:
// ^CharacterDevice
virtual ErrorOr<size_t> read(OpenFileDescription&, u64, UserOrKernelBuffer&, size_t) override;
virtual bool can_read(const OpenFileDescription&, size_t) const override;
virtual bool can_read(const OpenFileDescription&, u64) const override;
virtual ErrorOr<size_t> write(OpenFileDescription&, u64, const UserOrKernelBuffer&, size_t) override { return EINVAL; }
virtual bool can_write(const OpenFileDescription&, size_t) const override { return true; }