RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 14:02:46 +00:00
Code Issues Activity Actions

Notification: Remove default image

Browse source 
This takes up a lot of space if it is not used, and the default image
does not give value. Therefore, we hide the image widget if an invalid
image is passed.
This commit is contained in:
Nick Johnson 2021-03-12 12:00:56 -06:00 • committed by Andreas Kling
parent c7f00717c3
commit 9d09594e44
1 changed files with 8 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
Userland/Services/NotificationServer/NotificationWindow.cpp
View file

@ -38,7 +38,6 @@
namespace NotificationServer {
static HashMap<u32, RefPtr<NotificationWindow>> s_windows;
static const Gfx::Bitmap* default_image = Gfx::Bitmap::load_from_file("/res/icons/32x32/ladybug.png");
void update_notification_window_locations()
{
@ -94,7 +93,10 @@ NotificationWindow::NotificationWindow(i32 client_id, const String& text, const
widget.layout()->set_spacing(6);
m_image = &widget.add<GUI::ImageWidget>();
m_image->set_bitmap(icon.is_valid() ? icon.bitmap() : default_image);
m_image->set_visible(icon.is_valid());
if (icon.is_valid()) {
m_image->set_bitmap(icon.bitmap());
}
auto& left_container = widget.add<GUI::Widget>();
left_container.set_layout<GUI::VerticalBoxLayout>();
@ -141,7 +143,10 @@ void NotificationWindow::set_title(const String& value)
void NotificationWindow::set_image(const Gfx::ShareableBitmap& image)
{
m_image->set_bitmap(image.is_valid() ? image.bitmap() : default_image);
m_image->set_visible(image.is_valid());
if (image.is_valid()) {
m_image->set_bitmap(image.bitmap());
}
}
}