RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 14:57:34 +00:00
Code Issues Activity Actions

Kernel: Declare type aliases with "using" instead of "typedef"

Browse source 
This is the idiomatic way to declare type aliases in modern C++.
Flagged by Sonar Cloud as a "Code Smell", but I happen to agree
with this particular one. :^)
This commit is contained in:
Brian Gianforcaro 2021-09-04 11:02:38 -07:00 • committed by Linus Groh
parent 7463eb52e8
commit 9d1b27263f
7 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/Heap/Heap.h
View file

@ -176,8 +176,8 @@ class ExpandableHeap {
AK_MAKE_NONMOVABLE(ExpandableHeap);
public:
typedef ExpandHeap ExpandHeapType;
typedef Heap<CHUNK_SIZE, HEAP_SCRUB_BYTE_ALLOC, HEAP_SCRUB_BYTE_FREE> HeapType;
using ExpandHeapType = ExpandHeap;
using HeapType = Heap<CHUNK_SIZE, HEAP_SCRUB_BYTE_ALLOC, HEAP_SCRUB_BYTE_FREE>;
struct SubHeap {
HeapType heap;

2
Kernel/Heap/kmalloc.cpp
View file

@ -159,7 +159,7 @@ struct KmallocGlobalHeap {
return false;
}
};
typedef ExpandableHeap<CHUNK_SIZE, KMALLOC_SCRUB_BYTE, KFREE_SCRUB_BYTE, ExpandGlobalHeap> HeapType;
using HeapType = ExpandableHeap<CHUNK_SIZE, KMALLOC_SCRUB_BYTE, KFREE_SCRUB_BYTE, ExpandGlobalHeap>;
HeapType m_heap;
NonnullOwnPtrVector<Memory::Region> m_subheap_memory;