RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 05:47:35 +00:00
Code Issues Activity Actions

LibWeb: Support nullable EventListener parameters in WrapperGenerator

Browse source 
The internal C++ function will now receive a RefPtr<EventListener> for
'EventListener?' and a NonnullRefPtr<EventListener> for 'EventListener'.

Examples of this are addEventListener() and removeEventListener(), which
both have nullable callback parameters.
This commit is contained in:
Linus Groh 2021-04-10 18:51:29 +02:00 • committed by Andreas Kling
parent 2172e51246
commit 9d2635d94b
3 changed files with 29 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibWeb/DOM/EventTarget.cpp
View file

@ -39,19 +39,25 @@ EventTarget::~EventTarget()
{
}
void EventTarget::add_event_listener(const FlyString& event_name, NonnullRefPtr<EventListener> listener)
// https://dom.spec.whatwg.org/#add-an-event-listener
void EventTarget::add_event_listener(const FlyString& event_name, RefPtr<EventListener> listener)
{
if (listener.is_null())
return;
auto existing_listener = m_listeners.first_matching([&](auto& entry) {
return entry.listener->type() == event_name && &entry.listener->function() == &listener->function() && entry.listener->capture() == listener->capture();
});
if (existing_listener.has_value())
return;
listener->set_type(event_name);
m_listeners.append({ event_name, move(listener) });
m_listeners.append({ event_name, listener.release_nonnull() });
}
void EventTarget::remove_event_listener(const FlyString& event_name, NonnullRefPtr<EventListener> listener)
// https://dom.spec.whatwg.org/#remove-an-event-listener
void EventTarget::remove_event_listener(const FlyString& event_name, RefPtr<EventListener> listener)
{
if (listener.is_null())
return;
m_listeners.remove_first_matching([&](auto& entry) {
auto matches = entry.event_name == event_name && &entry.listener->function() == &listener->function() && entry.listener->capture() == listener->capture();
if (matches)