RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 17:58:12 +00:00
Code Issues Activity Actions

LibWeb: Do paint-order traversal in Document::elements_from_point()

Browse source 
Elements are now collected according to paint order as spec says,
replacing the depth-first traversal of the paint tree with hit-testing
on each box.

This change resolves a FIXME in an existing test and adds a new
previously non-working test.
This commit is contained in:
Aliaksandr Kalenik 2024-02-13 21:34:46 +01:00 • committed by Andreas Kling
parent 9c99182b1e
commit 9d2809146f
7 changed files with 68 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

37
Tests/LibWeb/Text/input/DOM/Elements-from-point-2.html Normal file
View file

@ -0,0 +1,37 @@
<!DOCTYPE html>
<style>
.box {
width: 100px;
height: 100px;
position: absolute;
}
#a {
background-color: magenta;
z-index: 1;
transform: translate(110px, 10px);
}
#b {
background-color: mediumaquamarine;
z-index: 2;
transform: translate(120px, 20px);
}
#c {
background-color: greenyellow;
z-index: 3;
transform: translate(130px, 30px);
}
</style>
<div id="a" class="box"></div>
<div id="b" class="box"></div>
<div id="c" class="box">hello</div>
<script src="../include.js"></script>
<script>
test(() => {
for (const element of document.elementsFromPoint(150, 50)) {
printElement(element)
}
});
</script>

18
Tests/LibWeb/Text/input/DOM/Elements-from-point-3.html Normal file
View file

@ -0,0 +1,18 @@
<div>
<p>Some text</p>
</div>
<p>Elements at point 30, 20:</p>
<div id="output"></div>
<script src="../include.js"></script>
<script>
test(() => {
let output = document.getElementById("output");
let elements = document.elementsFromPoint(30, 20);
elements.forEach((elt, i) => {
output.textContent += elt.localName;
if (i < elements.length - 1) {
output.textContent += " < ";
}
});
});
</script>

8
Tests/LibWeb/Text/input/DOM/Elements-from-point.html
View file

@ -32,15 +32,9 @@
for (let elem of document.elementsFromPoint(500, 10)) {
printElement(elem);
}
println("== FIXME: Elements at (550, 60) ==")
println("== Elements at (550, 60) ==")
for (let elem of document.elementsFromPoint(550, 60)) {
printElement(elem);
}
// FIXME: 550, 60 is supposed to print the following, but the algorithm is wrong.
// <DIV id="small-box" >
// <DIV id="large-box" >
// <PRE id="out" >
// <BODY >
// <HTML >
});
</script>