RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:17:36 +00:00
Code Issues Activity Actions

LibGL+LibSoftGPU: Calculate spotlight cutoff angle as degrees

Browse source 
We were storing the radians but never using that value in the GPU. We
now directly use the degrees value.
This commit is contained in:
Jelle Raaijmakers 2022-01-13 03:01:42 +01:00 • committed by Andreas Kling
parent 8c28d167c9
commit 9d4c2f6308
3 changed files with 1 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibGL/SoftwareGLContext.cpp
View file

@ -3007,7 +3007,6 @@ void SoftwareGLContext::sync_light_state()
light.spotlight_direction = current_light_state.spotlight_direction;
light.spotlight_exponent = current_light_state.spotlight_exponent;
light.spotlight_cutoff_angle = current_light_state.spotlight_cutoff_angle;
light.spotlight_cutoff_angle_rads = current_light_state.spotlight_cutoff_angle_rads;
light.constant_attenuation = current_light_state.constant_attenuation;
light.linear_attenuation = current_light_state.linear_attenuation;
light.quadratic_attenuation = current_light_state.quadratic_attenuation;
@ -3119,7 +3118,6 @@ void SoftwareGLContext::gl_lightf(GLenum light, GLenum pname, GLfloat param)
break;
case GL_SPOT_CUTOFF:
light_state.spotlight_cutoff_angle = param;
light_state.spotlight_cutoff_angle_rads = param * (AK::Pi<float> / 180.0f);
break;
default:
VERIFY_NOT_REACHED();
@ -3165,7 +3163,6 @@ void SoftwareGLContext::gl_lightfv(GLenum light, GLenum pname, GLfloat const* pa
break;
case GL_SPOT_CUTOFF:
light_state.spotlight_cutoff_angle = *params;
light_state.spotlight_cutoff_angle_rads = *params * (AK::Pi<float> / 180.0f);
break;
case GL_SPOT_DIRECTION: {
FloatVector4 direction_vector = { params[0], params[1], params[2], 0.0f };