RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:37:36 +00:00
Code Issues Activity Actions

LibWeb: Fix WebIDL overload resolution with platform object arguments

Browse source 
We now check if an argument value is a platform object that implements
the relevant IDL interface when resolving overloads.

This makes passing a Path2D object to CanvasRenderingContext2D.fill()
actually choose the Path2D overload. :^)
This commit is contained in:
Andreas Kling 2022-11-29 14:45:04 +01:00
parent 12ddeeb9ce
commit 9d4e0ba442
1 changed files with 7 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibWeb/WebIDL/OverloadResolution.cpp
View file

@ -159,10 +159,15 @@ JS::ThrowCompletionOr<ResolvedOverload> resolve_overload(JS::VM& vm, IDL::Effect
// - a union type, nullable union type, or annotated union type that has one of the above types in its flattened member types // - a union type, nullable union type, or annotated union type that has one of the above types in its flattened member types
// then remove from S all other entries. // then remove from S all other entries.
else if (value.is_object() && is<Bindings::PlatformObject>(value.as_object()) else if (value.is_object() && is<Bindings::PlatformObject>(value.as_object())
&& has_overload_with_argument_type_or_subtype_matching(overloads, i, [](IDL::Type const& type) { && has_overload_with_argument_type_or_subtype_matching(overloads, i, [value](IDL::Type const& type) {
// FIXME: - an interface type that V implements // - an interface type that V implements
if (static_cast<Bindings::PlatformObject const&>(value.as_object()).implements_interface(type.name()))
return true;
// - object
if (type.is_object()) if (type.is_object())
return true; return true;
return false; return false;
})) { })) {
overloads.remove_all_other_entries(); overloads.remove_all_other_entries();