RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 23:37:36 +00:00
Code Issues Activity Actions

LibWeb: Clamp {row,column} spans if outside of grid

Browse source 
A bug was found where grid items were being drawn outside of the grid if
the item had a large span and the grid was defined as having gaps
between the rows/columns.

This was caused by an erroneous calculation of the
{row,column}_{start,span} properties.
This commit is contained in:
Tom 2022-12-26 09:49:54 +01:00 • committed by Andreas Kling
parent ba86011fab
commit 9d5049230c
2 changed files with 21 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Base/res/html/misc/display-grid.html
View file

@ -139,7 +139,17 @@ that I don't quite understand. -->
">
<div class="grid-item">1</div>
</div>
<!-- Row-gaps with overflowing row spans. Github bug-->
<div
class="grid-container"
style="
grid-row-gap: 16px;
grid-template-rows: 1fr 1fr;
">
<div class="grid-item" style="grid-row: 2 / span 3;">1</div>
</div>
<p>End of crash tests</p>
<!-- Different column sizes -->