RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 13:12:46 +00:00
Code Issues Activity Actions

LibGUI: Fix leading whitespaces when text is wrapped

Browse source 
This commit should fix a bug where using leading whitespaces when a line
is wrapped results in a crash. Now it should correctly highlight the
leading whitespaces even when the leading whitespaces are longer than a
line.
This commit is contained in:
Young-Jin Park 2021-12-27 03:31:05 -08:00 • committed by Andreas Kling
parent 23037d619a
commit 9d74659f3b
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibGUI/TextEditor.cpp
View file

@ -653,12 +653,10 @@ void TextEditor::paint_event(PaintEvent& event)
painter.fill_rect_with_dither_pattern(whitespace_rect, Color(), Color(255, 192, 192));
}
}
if (m_visualize_leading_whitespace && line.leading_spaces() > 0) {
size_t physical_column = line.leading_spaces();
size_t end_of_leading_whitespace = (start_of_visual_line + physical_column);
size_t end_of_visual_line = (start_of_visual_line + visual_line_text.length());
if (end_of_leading_whitespace < end_of_visual_line) {
if (start_of_visual_line < physical_column) {
size_t end_of_leading_whitespace = min(physical_column - start_of_visual_line, visual_line_text.length());
Gfx::IntRect whitespace_rect {
content_x_for_position({ line_index, start_of_visual_line }),
visual_line_rect.y(),