RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:17:44 +00:00
Code Issues Activity Actions

Kernel: Use macros for GDT indices instead of hardcoding the values

Browse source
This commit is contained in:
Gunnar Beutner 2021-06-26 14:57:44 +02:00 • committed by Andreas Kling
parent 065c6c307d
commit 9d9f20391d
1 changed files with 2 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Kernel/Arch/x86/common/Interrupts.cpp
View file

@ -585,18 +585,16 @@ void unregister_generic_interrupt_handler(u8 interrupt_number, GenericInterruptH
UNMAP_AFTER_INIT void register_interrupt_handler(u8 index, void (*handler)()) UNMAP_AFTER_INIT void register_interrupt_handler(u8 index, void (*handler)())
{ {
// FIXME: Why is that with selector 8?
// FIXME: Is the Gate Type really required to be an Interrupt // FIXME: Is the Gate Type really required to be an Interrupt
// FIXME: What's up with that storage segment 0? // FIXME: What's up with that storage segment 0?
s_idt[index] = IDTEntry((FlatPtr)handler, 8, IDTEntryType::InterruptGate32, 0, 0); s_idt[index] = IDTEntry((FlatPtr)handler, GDT_SELECTOR_CODE0, IDTEntryType::InterruptGate32, 0, 0);
} }
UNMAP_AFTER_INIT void register_user_callable_interrupt_handler(u8 index, void (*handler)()) UNMAP_AFTER_INIT void register_user_callable_interrupt_handler(u8 index, void (*handler)())
{ {
// FIXME: Why is that with selector 8?
// FIXME: Is the Gate Type really required to be a Trap // FIXME: Is the Gate Type really required to be a Trap
// FIXME: What's up with that storage segment 0? // FIXME: What's up with that storage segment 0?
s_idt[index] = IDTEntry((FlatPtr)handler, 8, IDTEntryType::TrapGate32, 0, 3); s_idt[index] = IDTEntry((FlatPtr)handler, GDT_SELECTOR_CODE0, IDTEntryType::TrapGate32, 0, 3);
} }
UNMAP_AFTER_INIT void flush_idt() UNMAP_AFTER_INIT void flush_idt()