RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 23:08:11 +00:00
Code Issues Activity Actions

SharedGraphics: Font::load_from_file() forgot to close() the font file.

Browse source
This commit is contained in:
Andreas Kling 2019-02-03 08:17:35 +01:00
parent 1fffc0ae60
commit 9da9cce4f7
1 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

8
SharedGraphics/Font.cpp
View file

@ -154,12 +154,18 @@ RetainPtr<Font> Font::load_from_file(const String& path)
} }
auto* mapped_file = (byte*)mmap(nullptr, 4096 * 3, PROT_READ, MAP_SHARED, fd, 0); auto* mapped_file = (byte*)mmap(nullptr, 4096 * 3, PROT_READ, MAP_SHARED, fd, 0);
if (mapped_file == MAP_FAILED) if (mapped_file == MAP_FAILED) {
int rc = close(fd);
ASSERT(rc == 0);
return nullptr; return nullptr;
}
auto font = load_from_memory(mapped_file); auto font = load_from_memory(mapped_file);
int rc = munmap(mapped_file, 4096 * 3); int rc = munmap(mapped_file, 4096 * 3);
ASSERT(rc == 0); ASSERT(rc == 0);
rc = close(fd);
ASSERT(rc == 0);
return font; return font;
} }