diff --git a/Kernel/Devices/KCOVDevice.cpp b/Kernel/Devices/KCOVDevice.cpp index d621472ca3..d34475c92b 100644 --- a/Kernel/Devices/KCOVDevice.cpp +++ b/Kernel/Devices/KCOVDevice.cpp @@ -28,7 +28,7 @@ UNMAP_AFTER_INIT NonnullRefPtr KCOVDevice::must_create() } UNMAP_AFTER_INIT KCOVDevice::KCOVDevice() - : BlockDevice(30, 0) + : CharacterDevice(30, 0) { proc_instance = new HashMap(); thread_instance = new HashMap(); diff --git a/Kernel/Devices/KCOVDevice.h b/Kernel/Devices/KCOVDevice.h index 5c1ae79c0f..fa7cb89c3d 100644 --- a/Kernel/Devices/KCOVDevice.h +++ b/Kernel/Devices/KCOVDevice.h @@ -6,11 +6,11 @@ #pragma once -#include +#include #include namespace Kernel { -class KCOVDevice final : public BlockDevice { +class KCOVDevice final : public CharacterDevice { friend class DeviceManagement; public: @@ -32,7 +32,6 @@ protected: virtual bool can_read(OpenFileDescription const&, u64) const override final { return true; } virtual bool can_write(OpenFileDescription const&, u64) const override final { return true; } - virtual void start_request(AsyncBlockDeviceRequest& request) override final { request.complete(AsyncDeviceRequest::Failure); } virtual ErrorOr read(OpenFileDescription&, u64, UserOrKernelBuffer&, size_t) override { return EINVAL; } virtual ErrorOr write(OpenFileDescription&, u64, UserOrKernelBuffer const&, size_t) override { return EINVAL; } virtual ErrorOr ioctl(OpenFileDescription&, unsigned request, Userspace arg) override; diff --git a/Userland/Services/SystemServer/main.cpp b/Userland/Services/SystemServer/main.cpp index 5d0f767f02..795106df20 100644 --- a/Userland/Services/SystemServer/main.cpp +++ b/Userland/Services/SystemServer/main.cpp @@ -275,8 +275,8 @@ static void populate_devtmpfs_devices_based_on_devctl() break; } case 30: { - if (is_block_device) { - create_devtmpfs_block_device(String::formatted("/dev/kcov{}", minor_number), 0666, 30, minor_number); + if (!is_block_device) { + create_devtmpfs_char_device(String::formatted("/dev/kcov{}", minor_number), 0666, 30, minor_number); } break; }